Bayt.com

Start networking and exchanging professional insights

Register now or log in to join your professional community.

Follow

Employee getEmployee(int index) { return Employees[index]; } can you provide a code review?

Solution Design Solution Architecture Team Management SDLC iOS Development
user-image
Question added by Mohammad Shalabi , Cheif architect , Esatrata
Date Posted: 2014/09/20
Upvote (7) Views (3) Followers (7) Answers (1) Report Question
Write an Answer
Register now or log in to answer.
Mohammad Shalabi
by Mohammad Shalabi , Solution Architect, Android, and IOS Architect , ALM New Way

no defensive programming, what if employee is null. security issue, what Employees[-1] will return. design issue should use uint index as parameter.

Write Your Answer
More Questions Like This